Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node.statement overload typing - default argument #1317

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Fix node.statement overload typing - default argument #1317

merged 1 commit into from
Dec 29, 2021
+4 −2

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Dec 27, 2021

Description

As it turns out, the default arg is needed for astroid itself. We pass the future argument unconditionally to the parent call for which future can be None.

...
return self.parent.statement(future=future)

/CC: @DanielNoord

@cdce8p cdce8p added the task label Dec 27, 2021
@cdce8p cdce8p added this to the 2.9.1 milestone Dec 27, 2021
@cdce8p cdce8p mentioned this pull request Dec 27, 2021
Merged
Pierre-Sassoulas
Pierre-Sassoulas reviewed Dec 28, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there's an issue with distutils. ,Maybe due to https://bugs.python.org/msg394277 ? It's surprising that it fail for old python version too now.

@cdce8p
Copy link
Member Author

cdce8p commented Dec 29, 2021

It seems there's an issue with distutils. ,Maybe due to https://bugs.python.org/msg394277 ?

Not exactly, it's an issue with our hack around distutils and a new setuptools version which does some hacks itself.

It's surprising that it fail for old python version too now.

Bumping the cache version caused all environments to be recreated. That installed the latest setuptools version in every one of them which subsequently fail. 3.6 is fine as setuptools v60.0.0 requires Python 3.7.

Let's continue the discussion over in #1316

--
Since the test failures are unrelated, I'm going to merge this.

@cdce8p cdce8p merged commit 6e58cdf into pylint-dev:main Dec 29, 2021
@cdce8p cdce8p deleted the fix-statement-typing branch December 29, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas left review comments

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@cdce8p @Pierre-Sassoulas @DanielNoord